Telemetry: Don't count example stories towards CSF feature stats#30561
Merged
Conversation
shilman
added
bug
maintenance
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
shilman
changed the title
shilman
added
ci:normal
|
View your CI Pipeline Execution ↗ for commit 7cc29a4.
☁️ Nx Cloud last updated this comment at |
This was referenced Feb 18, 2025
Merged
shilman
added a commit
that referenced
this pull request
Feb 18, 2025
…ature-usage Telemetry: Don't count example stories towards CSF feature stats (cherry picked from commit 0673b6f)
github-actions
Bot
added
the
patch:done
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
We shouldn't count example stories since they are not for "real" components
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Modified StoryIndexGenerator to exclude example stories from feature usage statistics, ensuring more accurate metrics by only counting stories from real components.
isExampleStoryId()check inStoryIndexGenerator.tsbefore adding stats to summarysummarizeIndex.ts