Skip to content

Build: Fix local sandbox generation in linked mode #30471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 1 commit into from
Feb 5, 2025
Merged

Build: Fix local sandbox generation in linked mode #30471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions code/lib/cli-storybook/src/link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,6 @@ export const link = async ({ target, local, start }: LinkOptions) => {
reproDir = join(reprosDir, reproName);
}

const reproPackageJson = JSON.parse(
await readFile(join(reproDir, 'package.json'), { encoding: 'utf8' })
);

const version = spawnSync('yarn', ['--version'], {
cwd: reproDir,
stdio: 'pipe',
Expand All @@ -109,6 +105,10 @@ export const link = async ({ target, local, start }: LinkOptions) => {

logger.info(`Installing ${reproName}`);

const reproPackageJson = JSON.parse(
await readFile(join(reproDir, 'package.json'), { encoding: 'utf8' })
);

if (!reproPackageJson.devDependencies?.vite) {
reproPackageJson.devDependencies = {
...reproPackageJson.devDependencies,
Expand Down
6 changes: 5 additions & 1 deletion scripts/tasks/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import path from 'node:path';

import dirSize from 'fast-folder-size';
// eslint-disable-next-line depend/ban-dependencies
import { pathExists, remove } from 'fs-extra';
Expand Down Expand Up @@ -49,7 +51,8 @@ export const sandbox: Task = {

options.link = false;
}
if (await this.ready(details, options)) {

if (!(await this.ready(details, options))) {
logger.info('🗑 Removing old sandbox dir');
await remove(details.sandboxDir);
}
Comment thread
valentinpalkovic marked this conversation as resolved.
Expand Down Expand Up @@ -151,6 +154,7 @@ export const sandbox: Task = {

const packageManager = JsPackageManagerFactory.getPackageManager({}, details.sandboxDir);

await remove(path.join(details.sandboxDir, 'node_modules'));
await packageManager.installDependencies();
Comment thread
valentinpalkovic marked this conversation as resolved.
Comment thread
valentinpalkovic marked this conversation as resolved.

logger.info(`✅ Storybook sandbox created at ${details.sandboxDir}`);
Expand Down