Docs: Add CSF factory (experimental) snippets#30269
Closed
kylegach wants to merge 10 commits into
Closed
Conversation
kylegach
commented
Jan 15, 2025
| @@ -1,3 +1,93 @@ | |||
| ```js filename="Button.stories.js" renderer="common" language="js" tabTitle="CSF 3" | |||
Contributor
Author
There was a problem hiding this comment.
This diff is unfortunately hard to read. There are two required steps that aren't react-specific:
commonsnippets must be placed before thereactones- Add
tabTitle="CSF 3"tocommonsnippets
Contributor
Author
There was a problem hiding this comment.
The tags-in-preview.md diff is much easier to understand.
kylegach
commented
Jan 15, 2025
kylegach
force-pushed
the
docs-csf-4-snippets
branch
from
d0371d2 to
6825384
Compare
|
View your CI Pipeline Execution ↗ for commit 66c95e3.
☁️ Nx Cloud last updated this comment at |
* docs-csf-4: (45 commits) Improve clarity Stylistic preferences Stylistic preferences Remove unrelated CSF factory changes Docs: Fix syntax issues in documentation snippets Fix formatting Update yarn lock file Fix indentation Bump version from "8.6.0-alpha.0" to "8.6.0-alpha.1" [skip ci] Write changelog for 8.6.0-alpha.1 [skip ci] Replace `interaction test` -> `component test` Remove redundant browser configuration Update Vitest dependencies Add missing comma Addon Test: Support Vitest 3 Angular: Fix typings disable flaky test-runner tests Revert "Refactor Vitest browser configuration" Fix tests RNWVite: Support for requires in rnw for images/fonts ...
kylegach
force-pushed
the
docs-csf-4-snippets
branch
from
dd306eb to
5d7b457
Compare
kylegach
changed the title
This reverts commit ab46403.
…storybook into docs-csf-4-snippets
Contributor
Author
|
Closing in favor of #32357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add CSF factory (experimental) versions of code snippets when
reactis the active renderer, using tabs:Checklist for Contributors
Testing
Manual testing
reactand non-reactrenderers and for all languages (js,ts,ts-4-9)Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.