-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Addon-docs: Add eject button to canvas toolbar #29825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shilman
merged 15 commits into
storybookjs:next
from
mihkeleidast:add-eject-button-to-canvas-toolbar
Sep 28, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d5c7e81
feat: add eject button to canvas toolbar
mihkeleidast 19882e9
Merge branch 'next' into add-eject-button-to-canvas-toolbar
shilman 0724aa6
Merge branch 'next' into pr/29825
shilman 0e5234a
Merge branch 'next' into add-eject-button-to-canvas-toolbar
Sidnioulz 98b24a7
fix: add isLoading wrapper around eject button
mihkeleidast 089fd10
Merge branch 'next' into add-eject-button-to-canvas-toolbar
Sidnioulz 7757b7b
fix: bail out if loading or multi story preview
mihkeleidast 7d125a6
refactor: improve logic for loading states
mihkeleidast d566a44
Merge branch 'next' into add-eject-button-to-canvas-toolbar
mihkeleidast 8a93e13
fix: prefer aria-label over title attribute
mihkeleidast 5a4c18e
Merge branch 'next' into add-eject-button-to-canvas-toolbar
Sidnioulz 8f10421
Merge branch 'next' into add-eject-button-to-canvas-toolbar
Sidnioulz 315d015
Merge branch 'next' into add-eject-button-to-canvas-toolbar
Sidnioulz 283161b
Merge branch 'next' into add-eject-button-to-canvas-toolbar
Sidnioulz c3f22cf
Merge branch 'next' into add-eject-button-to-canvas-toolbar
shilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| import type { FC, MouseEvent as ReactMouseEvent, SyntheticEvent } from 'react'; | ||
| import type { FC, SyntheticEvent } from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| import { FlexBar, IconButton } from 'storybook/internal/components'; | ||
| import { FlexBar, IconButton, getStoryHref } from 'storybook/internal/components'; | ||
|
|
||
| import { ZoomIcon, ZoomOutIcon, ZoomResetIcon } from '@storybook/icons'; | ||
| import { ShareAltIcon, ZoomIcon, ZoomOutIcon, ZoomResetIcon } from '@storybook/icons'; | ||
|
|
||
| import { styled } from 'storybook/theming'; | ||
|
|
||
|
|
@@ -97,5 +97,26 @@ export const Toolbar: FC<ToolbarProps> = ({ | |
| </> | ||
| )} | ||
| </Wrapper> | ||
| {isLoading ? ( | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since storyId is resolved only after loading, changed the placeholder logic here to always show placeholder while loading, and then not rendering the actual button if storyId is not resolved. |
||
| <Wrapper key="right"> | ||
| <IconPlaceholder /> | ||
| </Wrapper> | ||
| ) : ( | ||
| baseUrl && | ||
| storyId && ( | ||
| <Wrapper key="right"> | ||
| <IconButton key="opener" asChild> | ||
| <a | ||
| href={getStoryHref(baseUrl, storyId)} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| aria-label="Open canvas in new tab" | ||
| > | ||
| <ShareAltIcon /> | ||
| </a> | ||
| </IconButton> | ||
| </Wrapper> | ||
| ) | ||
| )} | ||
| </Bar> | ||
| ); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a bail-out here for when: