Revert "Revert "Build: Migrate repo to Nx 20""#29821
Conversation
yannbf
added
build
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
12 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -188,9 +188,10 @@ | |||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0", | |||
There was a problem hiding this comment.
style: Wide version range for esbuild could lead to inconsistent builds. Consider pinning to specific version
| "type-fest": "~2.19", | ||
| "typescript": "^5.4.5", | ||
| "typescript": "5.4.5", |
There was a problem hiding this comment.
style: Pinning TypeScript to exact version 5.4.5 while other dependencies use ranges could cause version conflicts with other packages that depend on TypeScript
| const linkCommand = `npx nx affected -t check ${parallel}`; | ||
| const nolinkCommand = `npx nx affected -t check -c production ${parallel}`; |
There was a problem hiding this comment.
style: using npx requires package resolution on each run, which may impact performance in development
| @@ -12,8 +12,8 @@ const amountOfVCPUs = 4; | |||
| const parallel = `--parallel=${process.env.CI ? amountOfVCPUs - 1 : maxConcurrentTasks}`; | |||
There was a problem hiding this comment.
style: using amountOfVCPUs - 1 on CI but full maxConcurrentTasks locally could cause inconsistent behavior between environments
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b04c5a1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 56 | 56 | 0 |
| Self size | 129 KB | 129 KB | 0 B |
| Dependency size | 12.44 MB | 12.73 MB | 🚨 +286 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-addon-test
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 61 | 61 | 0 |
| Self size | 834 KB | 834 KB | 🚨 +5 B 🚨 |
| Dependency size | 13.86 MB | 14.15 MB | 🚨 +286 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 87 | 87 | 0 |
| Self size | 231 KB | 231 KB | 0 B |
| Dependency size | 31.28 MB | 31.57 MB | 🚨 +286 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 586 | 586 | 0 |
| Self size | 464 KB | 466 KB | 🚨 +2 KB 🚨 |
| Dependency size | 83.88 MB | 84.16 MB | 🚨 +286 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/test
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 53 | 53 | 0 |
| Self size | 1.52 MB | 1.81 MB | 🚨 +286 KB 🚨 |
| Dependency size | 8.09 MB | 8.09 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
3 participants
Attempt at understanding about the failure this PR caused, so we can bring it back once again!
Reverts #29820
Greptile Summary
This PR reverts a previous reversion, re-attempting to migrate the Storybook repository to Nx 20 with fixes for CI failures, including significant updates to build configuration and dependency management.
code/package.jsonand modified project configurationscode/migrations.jsonto clear migration history for a fresh start.nx/workspace-datato gitignore files and updated Vite config timestamp patternscode/frameworks/angular/project.jsonandcode/renderers/vue3/project.jsonscripts/tasks/to usenpx nxinstead of directnxcalls