Build: Exclude server action stories to run in next 13#29592
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 12be898. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| test: { | ||
| // This is needed until Next will update to the React 19 beta: https://github.com/vercel/next.js/pull/65058 | ||
| // In the React 19 beta ErrorBoundary errors (such as redirect) are only logged, and not thrown. | ||
| // We will also suspress console.error logs for re the console.error logs for redirect in the next framework. |
There was a problem hiding this comment.
syntax: typo in 'suspress' - should be 'suppress'
| import { redirect } from 'next/navigation'; | ||
|
|
||
| export async function accessRoute() { | ||
| const user = (await cookies()).get('user'); |
There was a problem hiding this comment.
style: Potential race condition - cookies() is called twice, once for await and once for get(). Use const cookieStore = await cookies() first
| } | ||
|
|
||
| export async function login() { | ||
| (await cookies()).set('user', 'storybookjs'); |
There was a problem hiding this comment.
style: No expiration time set for cookie, could lead to indefinite sessions
| revalidatePath('/'); | ||
| redirect(`/protected`); |
There was a problem hiding this comment.
logic: Calling revalidatePath() right before redirect() is unnecessary since the redirect will trigger a full page load
Build: Exclude server action stories to run in next 13 (cherry picked from commit 0676c9c)
github-actions
Bot
added
the
patch:done
ndelangen
removed
the
patch:yes
2 participants
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Added server action stories for Next.js pre-release template and moved existing stories to handle authentication flows with proper test coverage.
code/frameworks/nextjs/template/stories_nextjs-prerelease/ServerActions.stories.tsxwith test coverage for login/logout flowscode/frameworks/nextjs/template/stories_nextjs-prerelease/server-actions.tsximplementing cookie-based authenticationdangerouslyIgnoreUnhandledErrors