Docs: Correct addon-themes README to align text with code example#29548
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
jonniebigodes
approved these changes
Nov 6, 2024
Contributor
jonniebigodes
left a comment
There was a problem hiding this comment.
@schallerala thanks for taking the time to put together this pull request and helping us improve the documentation by catching this small typo. Appreciate it 🙏 !
I've checked and all is good on my end. I'll gladly merge this once the checklist clears.
Have a fantastic day.
Stay safe
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9d3dc83. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
none, fixing miss-alignment in documentation.
What I did
Align text block reference with below code.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
Checklist for Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates the README.md documentation for addon-themes to correct the parameter name for theme overrides from
themes.themeOverridetoglobals.theme, ensuring consistency with code examples./code/addons/themes/README.mdto useglobals.themeinstead ofthemes.themeOverride