CLI: Fix Solid init by installing @storybook/test#29514
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a10154e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This was referenced Nov 2, 2024
Merged
shilman
added a commit
that referenced
this pull request
Nov 5, 2024
CLI: Fix Solid init by installing `@storybook/test` (cherry picked from commit d130f0c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
We recently released https://github.com/storybookjs/solidjs/releases/tag/v1.0.0-beta.3 that updates the CLI templates to use
@storybook/testinstead of@storybook/testing-library. Thisstorybook initin a Solid project.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
If we were to release a canary, install it in a fresh Solid project. I've tested by hand already & it's a simple enough change.
At some point we should get the Solid sandboxes back into shape!
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates the Solid.js project initialization in Storybook CLI to use
@storybook/testinstead of@storybook/testing-library, aligning with the recentstorybook-solidjs@1.0.0-beta.3release.code/lib/create-storybook/src/generators/baseGenerator.tsto use@storybook/testfor Solid.js projects@storybook/testing-libraryfor Qwik projects only