Skip to content

CLI: Fix Solid init by installing @storybook/test#29514

Merged
shilman merged 1 commit into
nextfrom
shilman/fix-solid-init
Nov 2, 2024
Merged

CLI: Fix Solid init by installing @storybook/test#29514
shilman merged 1 commit into
nextfrom
shilman/fix-solid-init

Conversation

@shilman
Copy link
Copy Markdown
Member

@shilman shilman commented Nov 2, 2024

Closes N/A

What I did

We recently released https://github.com/storybookjs/solidjs/releases/tag/v1.0.0-beta.3 that updates the CLI templates to use @storybook/test instead of @storybook/testing-library. This storybook init in a Solid project.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

If we were to release a canary, install it in a fresh Solid project. I've tested by hand already & it's a simple enough change.

At some point we should get the Solid sandboxes back into shape!

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates the Solid.js project initialization in Storybook CLI to use @storybook/test instead of @storybook/testing-library, aligning with the recent storybook-solidjs@1.0.0-beta.3 release.

  • Modified code/lib/create-storybook/src/generators/baseGenerator.ts to use @storybook/test for Solid.js projects
  • Kept @storybook/testing-library for Qwik projects only
  • Change requires manual testing with a fresh Solid project installation

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch solid ci:normal Run our default set of CI jobs (choose this for most PRs). labels Nov 2, 2024
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a10154e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link
Copy Markdown

@JonahPlusPlus JonahPlusPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman added ci:normal Run our default set of CI jobs (choose this for most PRs). and removed ci:normal Run our default set of CI jobs (choose this for most PRs). labels Nov 2, 2024
@shilman shilman merged commit d130f0c into next Nov 2, 2024
@shilman shilman deleted the shilman/fix-solid-init branch November 2, 2024 02:36
shilman added a commit that referenced this pull request Nov 5, 2024
CLI: Fix Solid init by installing `@storybook/test`
(cherry picked from commit d130f0c)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 5, 2024
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). cli patch:done Patch/release PRs already cherry-picked to main/release branch solid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants