Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixes for 8.3 #29081

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Docs: Fixes for 8.3 #29081

merged 1 commit into from
Sep 11, 2024

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Sep 11, 2024

What I did

Docs fixes for 8.3

Checklist for Contributors

Testing

N/A

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

Greptile Summary

This pull request updates documentation and configuration for the Storybook Test addon, focusing on the Vitest plugin integration and terminology changes.

  • Updated documentation URLs from 'test-runner-with-vitest' to 'vitest-plugin' in code/addons/test/src/postinstall.ts
  • Corrected import statement for Sveltekit plugin in Vitest configuration example in docs/_snippets/vitest-plugin-vitest-config.md
  • Changed references from 'test runner with Vitest' to 'Vitest plugin' in docs/writing-tests/component-testing.mdx

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Sep 11, 2024
@kylegach kylegach self-assigned this Sep 11, 2024
@kylegach kylegach mentioned this pull request Sep 11, 2024
9 tasks
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Sep 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4280ec7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit 66b439e into next Sep 11, 2024
10 checks passed
@kasperpeulen kasperpeulen deleted the 8-3-docs-fixes branch September 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants