Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix typo in setup.mdx #29068

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Docs: Fix typo in setup.mdx #29068

merged 2 commits into from
Sep 9, 2024

Conversation

elbeezi
Copy link
Contributor

@elbeezi elbeezi commented Sep 6, 2024

What I did

Fixed a typo in the "Setup" docs page.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No manual testing necessary.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR addresses a minor typo in the Storybook setup documentation, improving its clarity and professionalism.

  • Fixed typo in docs/get-started/setup.mdx, changing "to learn how to hosting static files" to "to learn how to host static files"
  • Enhances readability of the "Load assets and resources" section in the setup guide

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@elbeezi elbeezi changed the title Fix typo in setup.mdx Docs: Fix typo in setup.mdx Sep 6, 2024
@jonniebigodes jonniebigodes self-assigned this Sep 6, 2024
@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Sep 9, 2024
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elbeezi thank you for taking the time to put together and help us improve the documentation by catching this small typo in the documentation. We appreciate it 🙏 ! I've checked and all is good on my end. I'll gladly merge this once the checklist clears.

Hope you have a great day and a fantastic week.

Stay safe

Copy link

nx-cloud bot commented Sep 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 97e40c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes merged commit 011f77d into storybookjs:next Sep 9, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
9 tasks
@elbeezi elbeezi deleted the patch-1 branch September 9, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants