Build: Use node 22 in monorepo

[ndelangen]

What I did

After moving away from esbuild-register we can upgrade to node 20!

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	before	after	diff	z	%
createSize	0 B	0 B	0 B	-	-
generateSize	76.3 MB	76.3 MB	-27.8 kB	-2	0%
initSize	171 MB	167 MB	-3.88 MB	-0.94	-2.3%
diffSize	95 MB	91.1 MB	-3.86 MB	-0.94	-4.2%
buildSize	7.42 MB	7.42 MB	0 B	-1	0%
buildSbAddonsSize	1.61 MB	1.61 MB	0 B	-1	0%
buildSbCommonSize	195 kB	195 kB	0 B	-	0%
buildSbManagerSize	2.29 MB	2.29 MB	0 B	-0.5	0%
buildSbPreviewSize	351 kB	351 kB	0 B	-	0%
buildStaticSize	0 B	0 B	0 B	-	-
buildPrebuildSize	4.45 MB	4.45 MB	0 B	-0.95	0%
buildPreviewSize	2.97 MB	2.97 MB	0 B	-1	0%
testBuildSize	0 B	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	17.8s	7.3s	-10s -484ms	-1.38	🔰-142.4%
generateTime	20.9s	22s	1.1s	-0.03	5.2%
initTime	18s	18.2s	198ms	-1.07	1.1%
buildTime	13.2s	11.9s	-1s -282ms	-1.62	🔰-10.7%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	8.7s	7.9s	-817ms	-0.39	-10.3%
devManagerResponsive	5.1s	4.9s	-246ms	-0.68	-5%
devManagerHeaderVisible	797ms	794ms	-3ms	-0.43	-0.4%
devManagerIndexVisible	822ms	835ms	13ms	-0.38	1.6%
devStoryVisibleUncached	1.2s	1s	-237ms	-1.39	🔰-23.6%
devStoryVisible	838ms	848ms	10ms	-0.44	1.2%
devAutodocsVisible	720ms	743ms	23ms	-0.2	3.1%
devMDXVisible	710ms	692ms	-18ms	-0.45	-2.6%
buildManagerHeaderVisible	753ms	713ms	-40ms	-0.67	-5.6%
buildManagerIndexVisible	756ms	718ms	-38ms	-0.68	-5.3%
buildStoryVisible	801ms	752ms	-49ms	-0.76	-6.5%
buildAutodocsVisible	669ms	637ms	-32ms	-1.1	-5%
buildMDXVisible	652ms	676ms	24ms	-0.19	3.6%

Greptile Summary

The PR updates the Storybook monorepo to use Node 20, including changes to dependencies and configurations to ensure compatibility.

• .circleci/config.yml: Updated Node.js version to 20.9.0 for various executors.
• .nvmrc: Updated to specify Node.js version 20.9.0.
• code/core/package.json: Updated @types/node to 20.0.0 and replaced mock-fs with memfs.
• code/core/src/common/utils/tests/interpret-files.test.ts: Replaced mock-fs with memfs for filesystem mocking.
• code/core/src/common/utils/tests/template.test.ts: Replaced mock-fs with memfs for filesystem mocking.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1f7250b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.

[greptile-apps]

LGTM

_{30 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[shilman]

Exciting! A few questions tho...

[shilman]

Is this a breaking change for users since it's a regular dependency?

[ndelangen]

I'll broaden this version range, to be on the safe side. I'm convinced this won't be breaking.

I'll see if it can be moved to a devDep, actually.

[levrik]

This change force-upgraded @types/node in our app repo to 22.x while we're using Node 18.x and don't want typings for a newer Node version (remember, these things are global). This effectively made Node 22.x the minimum required version of Node for Storybook with Webpack if you're using TypeScript. I think it should at least support the latest LTS which is 20.x. Better down to the lowest still supported release which is 18.x.