-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix collapse/expand all functionality #28582
UI: Fix collapse/expand all functionality #28582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated
collapse
menu item in/code/core/src/manager/container/Menu.tsx
to emitSTORIES_COLLAPSE_ALL
event - Removed deprecated
api.collapseAll
method call - Fixed error thrown when clicking 'Collapse All' due to missing method
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a dangling reference to collapseAll
in shortcuts.ts
. Can we fix that too?
fullAPI.collapseAll(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment to handle expandAll
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d4b319d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Closes #28457
Fix: Update Menu "Collapse All" option to emit STORIES_COLLAPSE_ALL
Issue: Clicking on "Collapse All" throws an error
api.collapseAll is not a function
Solution: Updated the
collapse
from the Menus.tsx component so it can emit the new events instead of calling the old methods.Testing
References:
Related issue: #28457
Related PR: #25486