Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updates for 8.2 features #28534

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Docs: Updates for 8.2 features #28534

merged 2 commits into from
Jul 10, 2024

Conversation

kylegach
Copy link
Contributor

What I did

Changes from #28452 & #28444, targeting main

Checklist for Contributors

Testing

N/A

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

…ries

Docs: Document portable stories usage
Docs: Add docs for mounting inside the play function
@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Jul 10, 2024
@kylegach kylegach self-assigned this Jul 10, 2024
Copy link

nx-cloud bot commented Jul 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 858f1b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kylegach kylegach merged commit 23882fe into main Jul 10, 2024
11 of 17 checks passed
@kylegach kylegach deleted the docs-8-2-updates-latest branch July 10, 2024 19:19
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated error message in code/core/src/preview-errors.ts for MountMustBeDestructuredError
  • Added docs/_snippets/before-all-in-preview.md and docs/_snippets/before-each-in-preview.md for initialization and MockDate usage
  • Improved snapshot testing in docs/_snippets/button-snapshot-test-portable-stories.md and docs/_snippets/component-test-with-testing-library.md
  • Added advanced usage examples in docs/_snippets/mount-advanced.md and docs/_snippets/mount-basic.md
  • Removed outdated snippets docs/_snippets/portable-stories-import-annotations.md and docs/_snippets/portable-stories-jest-with-loaders.md

27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant