Automigrations: Make VTA "learn more" link clickable #28020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Jun 10, 2024
shilman
added
bug
patch:yes
shilman
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 84079ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
11 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Automigrations: Make VTA "learn more" link clickable (cherry picked from commit e8a5c24)
Merged
6 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Automigrations: Make VTA "learn more" link clickable (cherry picked from commit e8a5c24)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Automigrations: Make VTA "learn more" link clickable (cherry picked from commit e8a5c24)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Automigrations: Make VTA "learn more" link clickable (cherry picked from commit e8a5c24)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The link in the 'visual-tests-addon' migration isn't properly clickable as it doesn't have a protocol
Documentation
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.