Added an event that is emitted when a channel is created. #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gongreg
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2711 +/- ##
==========================================
- Coverage 35.77% 35.75% -0.02%
==========================================
Files 433 433
Lines 9438 9441 +3
Branches 981 1005 +24
==========================================
Hits 3376 3376
+ Misses 5417 5376 -41
- Partials 645 689 +44
Continue to review full report at Codecov.
|
shilman
approved these changes
Jan 11, 2018
| @@ -42,16 +47,6 @@ export default class ReactProvider extends Provider { | |||
| const renderPreview = addons.getPreview(); | |||
|
|
|||
| const innerPreview = renderPreview ? renderPreview(kind, story) : null; | |||
|
|
|||
| if (this.options.manualId) { | |||
|
Seems reasonable to me. Can we use this to fix #1192? |
ndelangen
approved these changes
Jan 13, 2018
|
@shilman we should try it out and create a separate pr i guess. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Need ability to know when a channel was created between server and manager.
What I did
Added an event (copied logic from #1639).