Skip to content

Dependency: Upgrade webpack-virtual-modules to 0.6.0#27102

Merged
valentinpalkovic merged 4 commits into
storybookjs:nextfrom
fyodorovandrei:upgrade-webpack-virtual-modules
May 14, 2024
Merged

Dependency: Upgrade webpack-virtual-modules to 0.6.0#27102
valentinpalkovic merged 4 commits into
storybookjs:nextfrom
fyodorovandrei:upgrade-webpack-virtual-modules

Conversation

@fyodorovandrei

Copy link
Copy Markdown
Contributor

Closes #

What I did

Since I introduced a method to get virtual modules in the GitHub pull request #170, upgrading the package version will allow you to use this new method. Also, I removed the dev package @types/webpack-virtual-modules because the package bundles its own types as of version 0.4.2.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this May 13, 2024
@valentinpalkovic valentinpalkovic added dependencies builder-webpack5 ci:normal Run our default set of CI jobs (choose this for most PRs). labels May 13, 2024
@valentinpalkovic valentinpalkovic changed the title Feat: Upgrade webpack-virtual-modules to 0.6.0 Dependency: Upgrade webpack-virtual-modules to 0.6.0 May 14, 2024
@nx-cloud

nx-cloud Bot commented May 14, 2024

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 405b1f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic merged commit 0fe6c75 into storybookjs:next May 14, 2024
@github-actions github-actions Bot mentioned this pull request May 14, 2024
17 tasks
@fyodorovandrei fyodorovandrei deleted the upgrade-webpack-virtual-modules branch May 14, 2024 14:24
@fyodorovandrei

Copy link
Copy Markdown
Contributor Author

@valentinpalkovic Thank you for also updating the yarn.lock file. I made the changes via GitHub.dev, but I was unable to update it. I planned to clone repo locally later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builder-webpack5 ci:normal Run our default set of CI jobs (choose this for most PRs). dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants