Skip to content

Build: Fix nx affected, use the official orb#26663

Merged
kasperpeulen merged 5 commits into
nextfrom
kasper/fix-nx
Mar 27, 2024
Merged

Build: Fix nx affected, use the official orb#26663
kasperpeulen merged 5 commits into
nextfrom
kasper/fix-nx

Conversation

@kasperpeulen
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen commented Mar 27, 2024

What I did

Use the official orb of NX to make sure that the NX_BASE branch is set correctly for nx affected.
This makes sure that when run on next, the NX_BASE branch is set to the latest succesful check run on next.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:normal labels Mar 27, 2024
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e19d98d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Comment thread package.json
@kasperpeulen kasperpeulen merged commit 72d3370 into next Mar 27, 2024
@kasperpeulen kasperpeulen deleted the kasper/fix-nx branch March 27, 2024 14:19
@github-actions github-actions Bot mentioned this pull request Mar 27, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants