Skip to content

CI: Update Node.js versions in CircleCI config and .nvmrc#26645

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/bump-node-version-on-ci
Mar 27, 2024
Merged

CI: Update Node.js versions in CircleCI config and .nvmrc#26645
valentinpalkovic merged 1 commit into
nextfrom
valentin/bump-node-version-on-ci

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Mar 26, 2024

Closes N/A

What I did

Bumping the Node.js version on CI to support the latest Angular.js Prerelease sandbox since it requires 18.19.1.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Mar 26, 2024
@valentinpalkovic valentinpalkovic self-assigned this Mar 26, 2024
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 74e1718. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review March 26, 2024 13:45
@valentinpalkovic valentinpalkovic merged commit a832ca7 into next Mar 27, 2024
@valentinpalkovic valentinpalkovic deleted the valentin/bump-node-version-on-ci branch March 27, 2024 06:46
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 27, 2024
@github-actions github-actions Bot mentioned this pull request Mar 27, 2024
22 tasks
storybook-bot pushed a commit that referenced this pull request Mar 28, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
@github-actions github-actions Bot mentioned this pull request Mar 28, 2024
11 tasks
storybook-bot pushed a commit that referenced this pull request Mar 28, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Mar 28, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 1, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 1, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 2, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…-on-ci

CI: Update Node.js versions in CircleCI config and .nvmrc
(cherry picked from commit a832ca7)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 5, 2024
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants