Skip to content

Vue: Support defineModel and slots without bindings for vue-component-meta docgen plugin#26610

Merged
kasperpeulen merged 1 commit into
mainfrom
feat/update-vue-component-meta
Mar 25, 2024
Merged

Vue: Support defineModel and slots without bindings for vue-component-meta docgen plugin#26610
kasperpeulen merged 1 commit into
mainfrom
feat/update-vue-component-meta

Conversation

@larsrickert
Copy link
Copy Markdown
Contributor

@larsrickert larsrickert commented Mar 22, 2024

Closes: #26465
Closes: #25626

What I did

Update "vue-component-meta" which supports defineModel and slots without bindings in the new version.
I also added examples for the two use cases.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@larsrickert larsrickert changed the base branch from next to main March 22, 2024 08:43
@larsrickert larsrickert added ci:normal Run our default set of CI jobs (choose this for most PRs). feature request labels Mar 22, 2024
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a8f68f7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@chakAs3 chakAs3 added the vue3 label Mar 22, 2024
@chakAs3 chakAs3 self-assigned this Mar 22, 2024
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@kasperpeulen kasperpeulen merged commit eb8f745 into main Mar 25, 2024
@kasperpeulen kasperpeulen deleted the feat/update-vue-component-meta branch March 25, 2024 08:43
@hyshka
Copy link
Copy Markdown

hyshka commented Jul 15, 2024

Are there any plans for applying this to vue3-webpack5 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). feature request vue3

Projects

None yet

5 participants