Skip to content

API: Remove deprecated properties from manager-api#25578

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/remove-properties-from-api-stories-1
Jan 12, 2024
Merged

API: Remove deprecated properties from manager-api#25578
valentinpalkovic merged 1 commit into
nextfrom
valentin/remove-properties-from-api-stories-1

Conversation

@valentinpalkovic

@valentinpalkovic valentinpalkovic commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Closes #25361

What I did

Removed deprecated internal properties from manager-api.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jan 12, 2024
@valentinpalkovic valentinpalkovic self-assigned this Jan 12, 2024
@valentinpalkovic valentinpalkovic force-pushed the valentin/remove-properties-from-api-stories-1 branch from cb5d33e to eec6aaa Compare January 12, 2024 13:56
@valentinpalkovic valentinpalkovic merged commit 176fd77 into next Jan 12, 2024
@valentinpalkovic valentinpalkovic deleted the valentin/remove-properties-from-api-stories-1 branch January 12, 2024 14:28
@github-actions github-actions Bot mentioned this pull request Jan 12, 2024
27 tasks
@shilman shilman changed the title Remove deprecated properties from manager-api API: Remove deprecated properties from manager-api Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated properties from api-stories

2 participants