CLI: Fix using wrong package managers in existing projects

[JReinhold]

Closes #

What I did

Changed the order of how we determine which package manager to use. #23611 #24997 Introduced automatic inference based on which command was being run (eg. npx or yarn dlx). However that took priority over the lock file, meaning running npx storybook@next upgrade in a Yarn project would use npm and thus create an npm lockfile when it shouldn't. I don't think we should expect Yarn users to use yarn dlx over npx everywhere.

I believe the lock file should still be prioritized, and we should only infer it from the command if no lock file can be found - ie. when initing in an empty project.

This also fixed a minor bug where any npm WARN log messages during npm-check-updates in storybook upgrade would cause an error. We now correctly only throw an error if we see npm ERR in the logs.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25474-sha-c0c8ae28. Install it by pinning all your Storybook dependencies to that version.

More information

Published version	0.0.0-pr-25474-sha-c0c8ae28
Triggered by	@JReinhold
Repository	storybookjs/storybook
Branch	jeppe/fix-package-manager-issues
Commit	c0c8ae28
Datetime	Fri Jan 5 12:27:47 UTC 2024 (1704457667)
Workflow run	7421815964

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25474

[ShaunEvening]

Makes sense! Thank you for changing this, Jeppe <3

[valentinpalkovic]

@JReinhold The description is misleading since #23611 never get merged.