Skip to content

Docs: Update button-story-default-export-with-component.ts.mdx#25439

Merged
jonniebigodes merged 3 commits into
storybookjs:nextfrom
wuzhuobin:patch-2
Jan 7, 2024
Merged

Docs: Update button-story-default-export-with-component.ts.mdx#25439
jonniebigodes merged 3 commits into
storybookjs:nextfrom
wuzhuobin:patch-2

Conversation

@wuzhuobin
Copy link
Copy Markdown
Contributor

@wuzhuobin wuzhuobin commented Jan 3, 2024

Closes #

What I did

Fix incorrect export doc

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Jan 3, 2024
@jonniebigodes jonniebigodes changed the title Update button-story-default-export-with-component.ts.mdx Docs: Update button-story-default-export-with-component.ts.mdx Jan 7, 2024
Copy link
Copy Markdown
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuzhuobin, thanks for putting together this pull request and helping us improve the documentation by catching this small but rather important issue in our documentation. We appreciate it 🙏 ! I've checked and all is good on my end and going to merge this once the checklist clears.

Have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes merged commit 9596420 into storybookjs:next Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants