Skip to content

Core: Remove the -s flag from build & dev#25266

Merged
ndelangen merged 1 commit into
nextfrom
norbert/remove-deprecated-staticdirs-cli-flag
Dec 21, 2023
Merged

Core: Remove the -s flag from build & dev#25266
ndelangen merged 1 commit into
nextfrom
norbert/remove-deprecated-staticdirs-cli-flag

Conversation

@ndelangen

Copy link
Copy Markdown
Member

What I did

We said we'd remove it, let's remove it.

The CLI now no longer supports -s or --static-dir flags.
The only way to configure this is via main.ts

This PR likely needs documentation changes.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Dec 19, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks core ci:normal Run our default set of CI jobs (choose this for most PRs). labels Dec 19, 2023
@ndelangen ndelangen merged commit 1fbac12 into next Dec 21, 2023
@ndelangen ndelangen deleted the norbert/remove-deprecated-staticdirs-cli-flag branch December 21, 2023 10:06
@github-actions github-actions Bot mentioned this pull request Dec 21, 2023
12 tasks
@github-actions

github-actions Bot commented Jan 3, 2024

Copy link
Copy Markdown
Contributor
Fails
🚫 PR is marked with "BREAKING CHANGE" label.
🚫

Please choose only one of these labels: ["BREAKING CHANGE","maintenance"]

Generated by 🚫 dangerJS against 94f4361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE ci:normal Run our default set of CI jobs (choose this for most PRs). core maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants