-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
NextJS: Add experimental RSC support #25091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ca4cc16
NextJS: Add RSC support
shilman 2960d3d
React: Add RSC type support
shilman 048fa05
Revert "React: Add RSC type support"
shilman 0cfe045
Skip intentional error stories
shilman ffbd24f
Add more RSC stories
shilman 4a0e468
NextJS: Add experimentalNextRSC feature flag
shilman f27cb2b
NextJS: Add RSC support to README
shilman bef036f
Enable RSC in NextJS sandboxes
shilman 80b2a9e
Fix review comments
shilman 2a7052a
Merge branch 'next' into shilman/add-rsc
shilman 91db333
Merge branch 'next' into shilman/add-rsc
shilman 6433e19
Fix typo
shilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import type { Addon_DecoratorFunction } from '@storybook/types'; | ||
| import { ServerComponentDecorator } from './rsc/decorator'; | ||
|
|
||
| export const decorators: Addon_DecoratorFunction<any>[] = [ServerComponentDecorator]; | ||
|
|
||
| export const parameters = { | ||
| nextjs: { | ||
| rsc: true, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import * as React from 'react'; | ||
| import type { StoryContext } from '@storybook/react'; | ||
|
|
||
| export const ServerComponentDecorator = ( | ||
| Story: React.FC, | ||
| { parameters }: StoryContext | ||
| ): React.ReactNode => | ||
| parameters?.nextjs?.rsc ? ( | ||
| <React.Suspense> | ||
| <Story /> | ||
| </React.Suspense> | ||
| ) : ( | ||
| <Story /> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import React from 'react'; | ||
|
|
||
| export const RSC = async ({ label }) => <>RSC {label}</>; | ||
|
|
||
| export const Nested = async ({ children }) => <>Nested {children}</>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import React from 'react'; | ||
| import { RSC, Nested } from './RSC'; | ||
|
|
||
| export default { | ||
| component: RSC, | ||
| args: { label: 'label' }, | ||
| }; | ||
|
|
||
| export const Default = {}; | ||
|
|
||
| export const DisableRSC = { | ||
| tags: ['test-skip'], | ||
| parameters: { | ||
| chromatic: { disable: true }, | ||
| nextjs: { rsc: false }, | ||
| }, | ||
| }; | ||
|
|
||
| export const Error = { | ||
| tags: ['test-skip'], | ||
| parameters: { | ||
| chromatic: { disable: true }, | ||
| }, | ||
| render: () => { | ||
| throw new Error('RSC Error'); | ||
| }, | ||
| }; | ||
|
|
||
| export const NestedRSC = { | ||
| render: (args) => ( | ||
| <Nested> | ||
| <RSC {...args} /> | ||
| </Nested> | ||
| ), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.