Docs: Fix ArgTypes links#25084
Merged
Merged
Conversation
Contributor
Thanks for letting me know. This should be addressed in storybookjs/frontpage#641 |
kylegach
approved these changes
Dec 2, 2023
Contributor
kylegach
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
36 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
(cherry picked from commit 4a90af1)
Merged
11 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit 4a90af1)
44 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 4a90af1)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 4a90af1)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #22970
What I did
With this pull request, the ArgTypes links were updated to prevent them from 404ing in the documentation, whether viewing the source or, for instance, the pre-release version available. Originally reported here.
A simple test to verify this is to open the Vite builder pre-release documentation and click the link pointing to the ArgTypes documentation which will cause the 404. This can also be replicated by viewing the documentation in situ here on GitHub.
@kylegach I saw that you have a redirect in place, which helped out when the changes came online, but now is having a negative impact as the previous versions of the documentation are also 404ing (e.g., version 7.5, 7.4, etc). Can we mitigate this and set up something for those versions?
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>