Skip to content

Docs: Fix story anchors using encodeURIComponent#25062

Merged
valentinpalkovic merged 2 commits into
storybookjs:nextfrom
xyy94813:feature/subheading-tag-id
Dec 7, 2023
Merged

Docs: Fix story anchors using encodeURIComponent#25062
valentinpalkovic merged 2 commits into
storybookjs:nextfrom
xyy94813:feature/subheading-tag-id

Conversation

@xyy94813

Copy link
Copy Markdown
Contributor

Closes #25026

What I did

use encodeURIComponent to encode story name

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@xyy94813

Copy link
Copy Markdown
Contributor Author

I have run this script:

task --task e2e-tests --template=react-vite/default-ts --start-from=auto

And how to do unit tests and ntegration tests ???

@valentinpalkovic valentinpalkovic self-assigned this Dec 4, 2023
@valentinpalkovic valentinpalkovic added bug addon: docs ci:normal Run our default set of CI jobs (choose this for most PRs). labels Dec 4, 2023
@xyy94813

xyy94813 commented Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

@valentinpalkovic

Copy link
Copy Markdown
Contributor

No. Everything is just fine :) Thank you for your contribution!

@valentinpalkovic valentinpalkovic changed the title refactor: use encodeURIComponent to encode story name Docs: Use encodeURIComponent to encode story name Dec 7, 2023
@valentinpalkovic valentinpalkovic merged commit 7c32fb5 into storybookjs:next Dec 7, 2023
@shilman shilman changed the title Docs: Use encodeURIComponent to encode story name Docs: Fix story anchors with encodeURIComponent Dec 11, 2023
@shilman shilman changed the title Docs: Fix story anchors with encodeURIComponent Docs: Fix story anchors using encodeURIComponent Dec 11, 2023
@xyy94813 xyy94813 deleted the feature/subheading-tag-id branch December 20, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: docs bug ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Anchor for docs page Subheading wrong

2 participants