Docs: Make webpackFinal consistent across docs#25038
Conversation
jonniebigodes
left a comment
There was a problem hiding this comment.
@kylemeenehan, thanks for putting together this pull request and helping us improve the documentation by fixing these two snippets and standardizing the snippets for consistency. Appreciate it 🙏 ! I've checked, and I'm with you on this.
I'll gladly merge this once the checklist clears.
Hope you have a fantastic day.
Stay safe
No worries! Thanks for the great tool! Storybook makes my job a lot easier! |
What I did
Makes the implementation of
webpackFinalconsistent across documentation.In the documentation there is both,
and,
While these are both valid, I feel the documentation is easier to read if implementation is consistent?
I've aligned these cases to the style that is used elsewhere.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
None that I'm aware of?
Manual testing
I'm not sure how to run the docs locally? Apologies if I've missed that somewhere. Testing should be as follows:
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>