Skip to content

SvelteKit: Default to log an action for goto, invalidate and invalidateAll#24955

Merged
JReinhold merged 5 commits into
storybookjs:nextfrom
paoloricciuti:default-actions-for-goto
Nov 24, 2023
Merged

SvelteKit: Default to log an action for goto, invalidate and invalidateAll#24955
JReinhold merged 5 commits into
storybookjs:nextfrom
paoloricciuti:default-actions-for-goto

Conversation

@paoloricciuti

Copy link
Copy Markdown
Contributor

What I did

I've added a default of a new action for goto, invalidate and invalidateAll for sveltekit so if you don't specify a callback for them in sveltekit_experimental it will log an action.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Run a sandbox for template yarn task --task sandbox --start-from auto --template svelte-kit-skeleton-ts or yarn task --task sandbox --start-from auto --template svelte-kit-skeleton-js
  2. Open Storybook in your browser
  3. Access sveltekit/modules/navigation/default-actions story
  4. click on the buttons and verify that the actions are logged in the action panel

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold self-assigned this Nov 23, 2023
@JReinhold JReinhold added ci:daily Run the CI jobs that normally run in the daily job. sveltekit feature request labels Nov 23, 2023

@JReinhold JReinhold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💪

@JReinhold JReinhold changed the title SvelteKit: default to actions for goto, invalidate, invalidateall SvelteKit: Default to log an action for goto, invalidate and invalidateAll Nov 24, 2023
@JReinhold JReinhold merged commit 306c510 into storybookjs:next Nov 24, 2023
@github-actions github-actions Bot mentioned this pull request Nov 24, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:daily Run the CI jobs that normally run in the daily job. feature request sveltekit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants