NextJS: Verify Next runs on desired port & fail fast#24930
Merged
Conversation
tmeasday
requested changes
Nov 21, 2023
| const writePidFile = async (pid: number, { appDir }: { appDir: boolean }) => { | ||
| const routeDir = appDir ? join('app', '(sb)') : 'pages'; | ||
| const storybookDir = join(process.cwd(), routeDir, 'storybookPreview'); | ||
| const pidFile = join(storybookDir, 'pid.tsx'); |
Member
There was a problem hiding this comment.
I don't think this file name is right for the app dir?
Also this will overwrite the file every time we start, that's a bit icky. Can we do it with a middleware somehow?
shilman
changed the title
shilman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
NextJS doesn't start on the desired port if that port is already being used by another process. However our Storybook setup assumes that it is being run on the specified port and will fail if not. This check exits the process if another port is being used.
This is a strawman for discussion and shouldn't be merged as is. The code actually gets called twice with two different PIDs since
next-configgets evaluated twice. Consequently there is a race condition.Manual testing
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>