Skip to content

FastBuild: Fix disabledAddons filter#24924

Merged
ndelangen merged 3 commits into
nextfrom
fix-disabled-addons
Nov 22, 2023
Merged

FastBuild: Fix disabledAddons filter#24924
ndelangen merged 3 commits into
nextfrom
fix-disabled-addons

Conversation

@IanVS

@IanVS IanVS commented Nov 20, 2023

Copy link
Copy Markdown
Member

Closes #

Ref: #24837 (comment)

What I did

Fixed a bug which prevented any addons from being loaded in --test mode except addon-coverage and addon-docs.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

I tested this in my own app a little differently, but I'd recommend trying this:

  1. Build an app that uses a few addons, using --test.
  2. Without this fix, those addons won't be loaded. You might not even get an addons panel.
  3. With this fix, your addons should work fine.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@IanVS IanVS added bug ci:normal Run our default set of CI jobs (choose this for most PRs). labels Nov 20, 2023
@IanVS IanVS assigned kasperpeulen and unassigned kasperpeulen Nov 20, 2023
@IanVS IanVS requested a review from kasperpeulen November 20, 2023 21:35

@kasperpeulen kasperpeulen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@kasperpeulen kasperpeulen added ci:normal Run our default set of CI jobs (choose this for most PRs). and removed ci:normal Run our default set of CI jobs (choose this for most PRs). labels Nov 21, 2023
@IanVS

IanVS commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

I can't tell why yarn install is failing in CI, so I opened #24938 to save off the storybook log and hopefully that will give more info.

@ndelangen ndelangen merged commit 95f02fe into next Nov 22, 2023
@ndelangen ndelangen deleted the fix-disabled-addons branch November 22, 2023 08:10
@github-actions github-actions Bot mentioned this pull request Nov 22, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants