Skip to content

Svelte: Support v5 prereleases#24889

Merged
JReinhold merged 29 commits into
storybookjs:nextfrom
allozaur:allozaur/#24886
Dec 6, 2023
Merged

Svelte: Support v5 prereleases#24889
JReinhold merged 29 commits into
storybookjs:nextfrom
allozaur:allozaur/#24886

Conversation

@allozaur
Copy link
Copy Markdown

@allozaur allozaur commented Nov 17, 2023

Closes #24886

What I did

Changes for rendering stories for Svelte 5 where "Components are no longer classes"

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24889-sha-7abeedf4. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24889-sha-7abeedf4
Triggered by @JReinhold
Repository allozaur/storybook
Branch allozaur/#24886
Commit 7abeedf4
Datetime Thu Nov 30 09:30:10 UTC 2023 (1701336610)
Workflow run 7044517732

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24889

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Nov 17, 2023

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
svelte 5.0.0-next.19 None +10 3.25 MB svelte-admin
svelte-check 3.4.6...3.6.2 None +0/-0 8.84 MB svelte-language-tools-deploy

@shilman shilman added BREAKING CHANGE svelte maintenance User-facing maintenance tasks labels Nov 18, 2023
@shilman shilman changed the title Svelte 5 compatibility Svelte: Upgrade to v5 Nov 18, 2023
@JReinhold JReinhold changed the base branch from next to release-8-0 November 21, 2023 09:07
@storybook-bot
Copy link
Copy Markdown
Contributor

Failed to publish canary version of this pull request, triggered by @JReinhold. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/6958036201

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Nov 22, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@JReinhold JReinhold self-assigned this Nov 24, 2023
@github-actions github-actions Bot deleted the branch storybookjs:next November 28, 2023 23:24
@github-actions github-actions Bot closed this Nov 28, 2023
@ndelangen ndelangen reopened this Nov 29, 2023
@ndelangen ndelangen changed the base branch from release-8-0 to next November 29, 2023 08:00
@JReinhold
Copy link
Copy Markdown
Contributor

We're running into this issue currently: sveltejs/svelte#9716

It means that when you change a control, any of the controls that are unset will make the component discard the fallback value and turn undefined instead.

@JReinhold JReinhold changed the title Svelte: Upgrade to v5 Svelte: Support v5 prereleases Nov 30, 2023
Copy link
Copy Markdown
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! But the sandboxes should be generated in a separate branch that is not a fork

@JReinhold JReinhold added the ci:daily Run the CI jobs that normally run in the daily job. label Dec 1, 2023
@JReinhold
Copy link
Copy Markdown
Contributor

Sandbox is failing to be created because a transitive upstream package doesn't allow Svelte 5 yet: sveltejs/svelte-hmr#87

Comment thread scripts/tasks/sandbox-parts.ts Outdated
@JReinhold JReinhold removed the maintenance User-facing maintenance tasks label Dec 6, 2023
@JReinhold JReinhold merged commit 5aaa283 into storybookjs:next Dec 6, 2023
@JReinhold JReinhold mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:daily Run the CI jobs that normally run in the daily job. feature request svelte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Instantiating a component with new is no longer valid in Svelte 5.

7 participants