GitHub: Update help.yml#24868
Conversation
joevaugh4n
requested review from
JReinhold,
vanessayuenn and
yannbf
as code owners
kylegach
left a comment
kylegach
left a comment
There was a problem hiding this comment.
Left some suggestions and comments to address. Ping me when you're ready, and I'll merge for ya!
kylegach
added
build
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Hey @kylegach, thanks for the great feedback. Committed it. Unless there's anything else that I missed, please feel free to merge! |
vanessayuenn
left a comment
vanessayuenn
left a comment
There was a problem hiding this comment.
The content looks good to me. But it looks like there are still some errors with the formatting 😬
| label: Share an example | ||
| description: Help us debug your issue by creating a minimal reproduction. You can do this with StackBlitz by heading to [https://storybook.new](https://storybook.new)! | ||
| label: Create a reproduction | ||
| description: Help us debug by creating a minimal reproduction with [https://storybook.new](https://storybook.new) |
There was a problem hiding this comment.
We can add this link here also in case it's helpful: https://storybook.js.org/docs/react/contribute/how-to-reproduce
There was a problem hiding this comment.
Hey @vanessayuenn – I tried the edited code in a different forked version of Storybook and it looks like it works (pic below).
I can't get rid of the error messages in this branch – they don't even make sense because they refer to bits of code that aren't there. E.g. it says 'body[0]: validations is not a permitted attribute', but there isn't a validations attribute within that first key.
Any thoughts? Could we try merging and see if that resolves it/changes the errors?
Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
- Remove `render` attribute from Additional information textarea
- That property will force input into a code block, but we're asking for information that would best fit in multiple code blocks
- Add `id` for debugging purposes
- Attempt to fix formatting issues
|
@joevaugh4n — I pushed a commit with some minor updates. Looking more closely at those errors, they match the file that's on the As far as I can tell, the file in this PR fixes all of those errors. So, I think you're good to go! I'm going to merge it. |
5 participants
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
• Open up a help discussion
• Form should now work as syntax errors are resolved
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>