Skip to content

Angular: Handle nested module metadata #24798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 1 commit into from
Nov 10, 2023
+2 −2
Merged

Angular: Handle nested module metadata #24798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/frameworks/angular/src/client/angular-beta/utils/NgModulesAnalyzer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const isComponentAlreadyDeclared = (
): boolean => {
if (
moduleDeclarations &&
moduleDeclarations.some((declaration) => declaration === componentToFind)
moduleDeclarations.flat().some((declaration) => declaration === componentToFind)
) {
// Found component in declarations array
return true;
Expand All @@ -23,7 +23,7 @@ export const isComponentAlreadyDeclared = (
return false;
}

return moduleImports.some((importItem) => {
return moduleImports.flat().some((importItem) => {
const extractedNgModuleMetadata = extractNgModuleMetadata(importItem);
if (!extractedNgModuleMetadata) {
// Not an NgModule
Expand Down