Skip to content

UI: Logo fixed value#24726

Merged
cdedreuille merged 2 commits into
storybookjs:nextfrom
black-arm:ui-brand-size
Nov 7, 2023
Merged

UI: Logo fixed value#24726
cdedreuille merged 2 commits into
storybookjs:nextfrom
black-arm:ui-brand-size

Conversation

@black-arm

@black-arm black-arm commented Nov 6, 2023

Copy link
Copy Markdown

Closes #24702

What I did

I changed the style to Brand Img Component.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman added bug ui ci:normal Run our default set of CI jobs (choose this for most PRs). labels Nov 6, 2023
@ndelangen ndelangen changed the title ui: logo fixed value UI: Logo fixed value Nov 6, 2023

@cdedreuille cdedreuille left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @black-arm. I check the different values you proposed and setting a max-width of 150px and a max-height of 100px seems to work pretty well.

@cdedreuille cdedreuille merged commit c4ad73c into storybookjs:next Nov 7, 2023
@github-actions github-actions Bot mentioned this pull request Nov 7, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: brandImage resizes itself in wrong circumstances

3 participants