Skip to content

Addon-docs: Fix storybook MDX check #24696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 4 commits into from
Dec 11, 2023
Merged

Addon-docs: Fix storybook MDX check #24696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df2e7d8
Addon-docs: Fix storybook MDX check
shilman Nov 3, 2023
e2fb5b3
Merge branch 'next' into shilman/24644-is-story-mdx
kasperpeulen Dec 7, 2023
f73898f
Merge branch 'next' into shilman/24644-is-story-mdx
shilman Dec 11, 2023
0d6da75
Fix flakey unit test
shilman Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/addons/docs/src/plugins/mdx-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import remarkExternalLinks from 'remark-external-links';
import { createFilter } from '@rollup/pluginutils';
import { dirname, join } from 'path';

const isStorybookMdx = (id: string) => id.endsWith('stories.mdx') || id.endsWith('story.mdx');
const isStorybookMdx = (id: string) => id.endsWith('.stories.mdx') || id.endsWith('.story.mdx');

/**
* Storybook uses two different loaders when dealing with MDX:
Expand Down
3 changes: 2 additions & 1 deletion code/lib/cli/src/automigrate/fixes/missing-babelrc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ describe('missing-babelrc fix', () => {
).resolves.toBeNull();
});

it('prompts when babelrc file is missing and framework does not provide babel config', async () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('prompts when babelrc file is missing and framework does not provide babel config', async () => {
Comment thread
ndelangen marked this conversation as resolved.
await expect(
check({
packageManager,
Expand Down