Build: Remove lerna#24673
Conversation
4edc9eb to
ae3136a
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: lerna@6.6.2 |
yannbf
left a comment
There was a problem hiding this comment.
Lerna is still needed in certain places. If you search for its usage in .js or .sh files, you will see that it's needed in:
generate-sb-packages-versions.js: used to generate the versions.ts filebuild-package.js: used asyarn build <storybook-package-name>publish.sh: I don't know if we even use this, but it does need lerna
|
I would also assume that all those scripts still referencing |
fe441ab to
6a619a3
Compare
|
Good catch @yannbf! Applied the requested changes |
|
Does this need any manual steps to test? |
|
|
@ndelangen, @yannbf Applied the requested changes! |
yannbf
left a comment
There was a problem hiding this comment.
The yarn build <package> command now does not give any output on success, and just crashes on error, instead of providing the correct error message like before. Can you fix that?
8286a8d to
85fe759
Compare
|
@yannbf Fixed! |
Closes N/A
What I did
Remove lerna as a dependency since it is not needed anymore.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>