Skip to content

Build: Remove lerna#24673

Merged
valentinpalkovic merged 8 commits into
nextfrom
valentin/remove-lerna
Nov 7, 2023
Merged

Build: Remove lerna#24673
valentinpalkovic merged 8 commits into
nextfrom
valentin/remove-lerna

Conversation

@valentinpalkovic

Copy link
Copy Markdown
Contributor

Closes N/A

What I did

Remove lerna as a dependency since it is not needed anymore.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added dependencies ci:normal Run our default set of CI jobs (choose this for most PRs). labels Nov 2, 2023
@valentinpalkovic valentinpalkovic self-assigned this Nov 2, 2023
@socket-security

Copy link
Copy Markdown

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: lerna@6.6.2

@yannbf yannbf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lerna is still needed in certain places. If you search for its usage in .js or .sh files, you will see that it's needed in:

  • generate-sb-packages-versions.js: used to generate the versions.ts file
  • build-package.js: used as yarn build <storybook-package-name>
  • publish.sh: I don't know if we even use this, but it does need lerna

@JReinhold

Copy link
Copy Markdown
Contributor

I would also assume that all those scripts still referencing lerna should be deleted.

@valentinpalkovic

Copy link
Copy Markdown
Contributor Author

Good catch @yannbf! Applied the requested changes

Comment thread scripts/build-package.js Outdated
Comment thread scripts/utils/workspace.ts
@ndelangen

Copy link
Copy Markdown
Member

Does this need any manual steps to test?
Maybe test the scripts @yannbf mentioned?

@valentinpalkovic

Copy link
Copy Markdown
Contributor Author
  • generate-sb-packages-versions.js is not in use anymore. scripts/release/version.ts will bump the versions in the generated versions.ts file
  • publish.sh is not in use anymore

@valentinpalkovic

Copy link
Copy Markdown
Contributor Author

@ndelangen, @yannbf Applied the requested changes!

@yannbf yannbf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yarn build <package> command now does not give any output on success, and just crashes on error, instead of providing the correct error message like before. Can you fix that?

@valentinpalkovic

Copy link
Copy Markdown
Contributor Author

@yannbf Fixed!

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Nov 6, 2023
@ndelangen ndelangen changed the title Dependencies: Remove lerna Build: Remove lerna Nov 6, 2023

@yannbf yannbf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome <3

@valentinpalkovic valentinpalkovic merged commit 063d79a into next Nov 7, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/remove-lerna branch November 7, 2023 14:35
@github-actions github-actions Bot mentioned this pull request Nov 7, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants