Skip to content

CLI: Ignore addon-onboarding when checking versions#24634

Merged
valentinpalkovic merged 1 commit into
nextfrom
fix-onboarding-warning
Oct 31, 2023
Merged

CLI: Ignore addon-onboarding when checking versions#24634
valentinpalkovic merged 1 commit into
nextfrom
fix-onboarding-warning

Conversation

@JReinhold

Copy link
Copy Markdown
Contributor

What I did

Added @storybook/addon-onboarding to list of non-core packages. Using sb upgrade would cause a warning to show like this, which was misleading:

WARN Found 1 outdated packages (relative to '@storybook/addon-essentials@7.5.2')
WARN Please make sure your packages are updated to ensure a consistent experience.
WARN - @storybook/addon-onboarding@1.0.8

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold added bug cli ci:normal Run our default set of CI jobs (choose this for most PRs). labels Oct 31, 2023
@JReinhold JReinhold self-assigned this Oct 31, 2023
@valentinpalkovic valentinpalkovic merged commit e3bc4e1 into next Oct 31, 2023
@valentinpalkovic valentinpalkovic deleted the fix-onboarding-warning branch October 31, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants