Skip to content

UI: Update zIndex on NotificationList to fix the notification not being clickable in certain cases#24602

Merged
cdedreuille merged 1 commit into
storybookjs:nextfrom
yoshi2no:patch/24476/yoshi2no
Nov 2, 2023
Merged

UI: Update zIndex on NotificationList to fix the notification not being clickable in certain cases#24602
cdedreuille merged 1 commit into
storybookjs:nextfrom
yoshi2no:patch/24476/yoshi2no

Conversation

@yoshi2no

Copy link
Copy Markdown
Contributor

Closes #24476

What I did

Modified the z-index value in NotificationList from 10 to 11 to ensure the NotificationList always closes when the X button is pressed.

The reason I changed the z-index to 11 is because the z-index of the line section that allows for width adjustment of the side menu was set to 10. If there's a more appropriate value to be set, I'd like to change it to that.

before after
https://github.com/storybookjs/storybook/assets/57059705/9ed4f961-353b-4b77-a051-efe550cdecc1 https://github.com/storybookjs/storybook/assets/57059705/12be530b-642c-4a80-8e15-7ee0ae132dbd

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, react-vite-default-ts
  2. In code/lib/manager-api/src/modules/whatsnew.ts, do the following to intentionally display notifications.
  const initModule = async () => {

   // remove if statement
    fullAPI.addNotification({
      id: WHATS_NEW_NOTIFICATION_ID,
      link: '/settings/whats-new',
      content: {
        headline: 'issue #24476',
        subHeadline: "Click to learn what's new in Storybook",
      },
      icon: { name: 'hearthollow' },
      onClear({ dismissed }) {
        if (dismissed) {
          setWhatsNewCache({ lastDismissedPost: 'https://' });
        }
      },
    });
  };
  1. Verify that the notification disappears when the X button is clicked.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic

Copy link
Copy Markdown
Contributor

@cdedreuille Can you take this?

@ndelangen ndelangen added bug ui ci:normal Run our default set of CI jobs (choose this for most PRs). labels Oct 30, 2023
@ndelangen ndelangen changed the title fix: storybook update toast can't be closed by the X button if the X button is on top of the border between the panes UI: update toast can't be closed if the close button at certain widths Oct 30, 2023

@cdedreuille cdedreuille left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for making that change @yoshi2no

@cdedreuille cdedreuille changed the title UI: update toast can't be closed if the close button at certain widths UI: Update zIndex on NotificationList to fix the notification not being clickable in certain cases Nov 2, 2023
@cdedreuille cdedreuille merged commit fbc8624 into storybookjs:next Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: storybook update toast can't be closed by the X button if the X button is on top of the border between the panes

4 participants