Skip to content

CLI: Add @storybook/addon-designs to non-core list#24507

Merged
valentinpalkovic merged 1 commit into
nextfrom
yann/addon-designs-exclude
Oct 18, 2023
Merged

CLI: Add @storybook/addon-designs to non-core list#24507
valentinpalkovic merged 1 commit into
nextfrom
yann/addon-designs-exclude

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Oct 18, 2023

Closes #

What I did

Added @storybook/addon-designs to non-core list of packages, so that storybook add @storybook/addon-designs works correctly. It was looking for a version that matched the installed Storybook version, which was incorrect. It should just use latest. Else it results in:

An error occurred while installing dependencies:
YARN2 error YN0001 - EXCEPTION: @storybook/addon-designs@npm:^7.5.0: No candidates found

Please check the logfile generated at ./storybook.log for troubleshooting and try again.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Run path/to/cli/bin.js add @storybook/addon-designs
  3. It should work

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug cli ci:normal Run our default set of CI jobs (choose this for most PRs). labels Oct 18, 2023
@valentinpalkovic valentinpalkovic merged commit c27dd83 into next Oct 18, 2023
@valentinpalkovic valentinpalkovic deleted the yann/addon-designs-exclude branch October 18, 2023 17:41
@github-actions github-actions Bot mentioned this pull request Oct 18, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants