Skip to content

UI: Fix className missing in syntaxhighlighter#24491

Merged
ndelangen merged 1 commit into
nextfrom
norbert/fix-highlighting-colors
Oct 17, 2023
Merged

UI: Fix className missing in syntaxhighlighter#24491
ndelangen merged 1 commit into
nextfrom
norbert/fix-highlighting-colors

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Oct 17, 2023

What I did

  • We found a regression where the colors were not applied in the syntaxhighlighter.
  • We discovered that in this PR: UI: Update ScrollArea with radix #24413 the regression was introduced.
  • We noticed that a className was not passed through in a component, we added this passthrough back.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Chromatic should show the appropriate diffs, the relevant stories are the docs block for source as well as the stories for the syntax-highlighter.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Oct 17, 2023
@ndelangen ndelangen added bug ci:docs Run the CI jobs for documentation checks only. ci:normal Run our default set of CI jobs (choose this for most PRs). ui and removed ci:docs Run the CI jobs for documentation checks only. labels Oct 17, 2023
@ndelangen ndelangen merged commit 4fa8c19 into next Oct 17, 2023
@ndelangen ndelangen deleted the norbert/fix-highlighting-colors branch October 17, 2023 15:53
JReinhold added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant