Skip to content

Angular: Add CLI options (debugWebpack, webpackStatsJson, and more) #24388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yannbf merged 1 commit into from
Oct 5, 2023
Merged

Angular: Add CLI options (debugWebpack, webpackStatsJson, and more) #24388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions code/frameworks/angular/src/builders/build-storybook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export type StorybookBuilderOptions = JsonObject & {
| 'webpackStatsJson'
| 'disableTelemetry'
| 'debugWebpack'
| 'previewUrl'
>;

export type StorybookBuilderOutput = JsonObject & BuilderOutput & { [key: string]: any };
Expand Down Expand Up @@ -90,6 +91,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (
debugWebpack,
disableTelemetry,
assets,
previewUrl,
} = options;

const standaloneOptions: StandaloneBuildOptions = {
Expand All @@ -111,6 +113,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (
tsConfig,
webpackStatsJson,
debugWebpack,
previewUrl,
};

return standaloneOptions;
Expand Down
4 changes: 4 additions & 0 deletions code/frameworks/angular/src/builders/build-storybook/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@
"description": "Write Webpack Stats JSON to disk",
"default": false
},
"previewUrl": {
"type": "string",
"description": "Disables the default storybook preview and lets you use your own"
},
"styles": {
"type": "array",
"description": "Global styles to be included in the build.",
Expand Down
9 changes: 9 additions & 0 deletions code/frameworks/angular/src/builders/start-storybook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ export type StorybookBuilderOptions = JsonObject & {
| 'open'
| 'docs'
| 'debugWebpack'
| 'webpackStatsJson'
| 'loglevel'
| 'previewUrl'
>;

export type StorybookBuilderOutput = JsonObject & BuilderOutput & {};
Expand Down Expand Up @@ -105,6 +108,9 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (options, cont
initialPath,
open,
debugWebpack,
loglevel,
webpackStatsJson,
previewUrl,
} = options;

const standaloneOptions: StandaloneOptions = {
Expand Down Expand Up @@ -133,6 +139,9 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (options, cont
initialPath,
open,
debugWebpack,
loglevel,
webpackStatsJson,
previewUrl,
};

return standaloneOptions;
Expand Down
14 changes: 14 additions & 0 deletions code/frameworks/angular/src/builders/start-storybook/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,20 @@
"initialPath": {
"type": "string",
"description": "URL path to be appended when visiting Storybook for the first time"
},
"webpackStatsJson": {
"type": "string",
"description": "Write Webpack Stats JSON to disk",
"default": false
},
"previewUrl": {
"type": "string",
"description": "Disables the default storybook preview and lets you use your own"
},
"loglevel": {
"type": "string",
"description": "Controls level of logging during build. Can be one of: [silly, verbose, info (default), warn, error, silent].",
"pattern": "(silly|verbose|info|warn|silent)"
}
},
"additionalProperties": false,
Expand Down