Skip to content

Docs: Add instructions for installing yarn#24386

Merged
jonniebigodes merged 5 commits into
nextfrom
yarn-instructions
Oct 9, 2023
Merged

Docs: Add instructions for installing yarn#24386
jonniebigodes merged 5 commits into
nextfrom
yarn-instructions

Conversation

@IanVS
Copy link
Copy Markdown
Member

@IanVS IanVS commented Oct 5, 2023

Closes #

What I did

I realized after setting up a new computer that I did not have yarn installed, and I was curious what Storybook's recommended method was and what version you needed, etc. I see that you have "packageManager": "yarn@3.5.1" already in the package.json, so all that's needed is a corepack enable, since Node 16 supports corepack.

So, I added that to the code contributing docs.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@IanVS IanVS changed the title Add instructions for installing yarn Docs: Add instructions for installing yarn Oct 5, 2023
@jonniebigodes jonniebigodes self-assigned this Oct 6, 2023
@jonniebigodes jonniebigodes added the ci:docs Run the CI jobs for documentation checks only. label Oct 6, 2023
Copy link
Copy Markdown
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanVS, thanks for taking the time to put together this small but rather important bit of information for the documentation. Appreciate it 🙏 ! I spotted one small capitalization issue, which I already fixed, and this should be good to go. I'll merge it once the checklist clears.

Hope you have a fantastic week.

Stay safe

@jonniebigodes jonniebigodes merged commit d42aae3 into next Oct 9, 2023
@jonniebigodes jonniebigodes deleted the yarn-instructions branch October 9, 2023 19:53
@github-actions github-actions Bot mentioned this pull request Oct 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants