Skip to content

Fix zone.js legacy deep import#24354

Merged
valentinpalkovic merged 3 commits into
storybookjs:valentin/fix-angular-sandboxfrom
greut:fix/gh-24297
Oct 4, 2023
Merged

Fix zone.js legacy deep import#24354
valentinpalkovic merged 3 commits into
storybookjs:valentin/fix-angular-sandboxfrom
greut:fix/gh-24297

Conversation

@greut
Copy link
Copy Markdown
Contributor

@greut greut commented Oct 3, 2023

Closes #24297

What I did

Removed zone.js deep import, that has been removed. See: https://github.com/angular/angular/blob/main/packages/zone.js/CHANGELOG.md#breaking-changes

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Signed-off-by: Yoan Blanc <yoan.blanc@ailly.dental>
@yannbf
Copy link
Copy Markdown
Member

yannbf commented Oct 4, 2023

Hey @greut thanks for this contribution! How does it play out with older angular versions (we support 14 and higher)?

@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/angular15-fix October 4, 2023 12:20
@valentinpalkovic valentinpalkovic changed the base branch from valentin/angular15-fix to next October 4, 2023 12:20
@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/angular15-fix October 4, 2023 12:20
@valentinpalkovic valentinpalkovic changed the base branch from valentin/angular15-fix to valentin/fix-angular-sandbox October 4, 2023 12:21
@valentinpalkovic valentinpalkovic merged commit d2ed2d4 into storybookjs:valentin/fix-angular-sandbox Oct 4, 2023
@greut greut deleted the fix/gh-24297 branch October 6, 2023 08:53
@greut
Copy link
Copy Markdown
Contributor Author

greut commented Oct 6, 2023

Hey @greut thanks for this contribution! How does it play out with older angular versions (we support 14 and higher)?

It's been there for a while, 0.11

https://github.com/angular/angular/blob/main/packages/zone.js/CHANGELOG.md#breaking-changes-since-zonejs-v0111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: zone.js incompatibilty

3 participants