Skip to content

Revert "Build: Cancel when the PR count is 0"#24293

Merged
shilman merged 1 commit into
nextfrom
revert-24274-norbert/gh-pr-creation-bug-fixed
Sep 24, 2023
Merged

Revert "Build: Cancel when the PR count is 0"#24293
shilman merged 1 commit into
nextfrom
revert-24274-norbert/gh-pr-creation-bug-fixed

Conversation

@shilman
Copy link
Copy Markdown
Member

@shilman shilman commented Sep 24, 2023

Reverts #24274

@shilman shilman merged commit 43b7366 into next Sep 24, 2023
@shilman shilman deleted the revert-24274-norbert/gh-pr-creation-bug-fixed branch September 24, 2023 18:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 24, 2023

Fails
🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

Generated by 🚫 dangerJS against 12be604

@github-actions github-actions Bot mentioned this pull request Sep 24, 2023
20 tasks
@ndelangen
Copy link
Copy Markdown
Member

@JReinhold Let's chat about this one later this week?

@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Oct 3, 2023
@JReinhold
Copy link
Copy Markdown
Contributor

@ndelangen I re-added it to my bigger release tooling PR #24106 . The problem was that the code was never merged to main, which it expected, causing it to crash. I added a secondary check that just makes it work as usual until it's merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants