Skip to content

NextJS: Fix default next image loader when src has params #24187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 6 commits into from
Oct 5, 2023
Merged

NextJS: Fix default next image loader when src has params #24187

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72a8744
Fix default next image loader when src has params
hazzard993 Sep 15, 2023
984d156
Use URL to fix next image loader src params
hazzard993 Sep 15, 2023
c4ba760
Remove double default in next image default loader
hazzard993 Sep 15, 2023
a683939
Merge branch 'next' into fix-next-image-search-params
ndelangen Sep 19, 2023
cb39a1f
Merge branch 'next' into fix-next-image-search-params
ndelangen Sep 21, 2023
74040b7
Merge branch 'next' into fix-next-image-search-params
valentinpalkovic Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions code/frameworks/nextjs/src/images/next-image-default-loader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type * as _NextImage from 'next/image';

export const defaultLoader = ({ src, width, quality }: _NextImage.ImageLoaderProps) => {
export const defaultLoader = ({ src, width, quality = 75 }: _NextImage.ImageLoaderProps) => {
const missingValues = [];
if (!src) {
missingValues.push('src');
Expand All @@ -24,5 +24,16 @@ export const defaultLoader = ({ src, width, quality }: _NextImage.ImageLoaderPro
);
}

return `${src}?w=${width}&q=${quality ?? 75}`;
const url = new URL(src, window.location.href);

if (!url.searchParams.has('w') && !url.searchParams.has('q')) {
url.searchParams.set('w', width.toString());
url.searchParams.set('q', quality.toString());
}

if (!src.startsWith('http://') && !src.startsWith('https://')) {
return url.toString().slice(url.origin.length);
}

return url.toString();
};