Skip to content

Git: Disable crlf to match prettier rules#24164

Merged
ndelangen merged 1 commit into
storybookjs:nextfrom
decherneyge:my-first-storybook-contribution
Sep 14, 2023
Merged

Git: Disable crlf to match prettier rules#24164
ndelangen merged 1 commit into
storybookjs:nextfrom
decherneyge:my-first-storybook-contribution

Conversation

@decherneyge
Copy link
Copy Markdown
Contributor

@decherneyge decherneyge commented Sep 13, 2023

What I did

Disables gits line end conversion for "text" files at the repository level so that windows devs that might have their global setting of autocrlf=true dont have this repository converted to crlfs and then face a wall of red errors from the prettier rules about not using cr

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

There should be no manual testing necessary.

Documentation

No documentation needed.

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

@ndelangen ndelangen self-assigned this Sep 13, 2023
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Sep 13, 2023
@ndelangen ndelangen changed the title explicitly disable crlf to match prettier rules Git: Disable crlf to match prettier rules Sep 13, 2023
@ndelangen ndelangen merged commit 0ae48b0 into storybookjs:next Sep 14, 2023
@decherneyge decherneyge deleted the my-first-storybook-contribution branch September 14, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants