Docs: fix continuous integration example#24054
Conversation
Update to fix errors with fetch-depth
jonniebigodes
left a comment
There was a problem hiding this comment.
@natehouk appreciate you taking the time to put together this pull request and catching this small but rather important typo in the documentation 🙏 ! Left one small item for you to look at when you have a moment.
Let me know, and we'll take it from there.
Hope you have a fantastic week.
Stay safe
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 20 | ||
| cache: 'npm' |
There was a problem hiding this comment.
@natehouk when you're able, can you revert this to include yarn? Also, if you're going to reference a node version, could you instead point it to the stable release, as not all users are already on version 20, which could introduce some unwanted issues?
There was a problem hiding this comment.
@jonniebigodes I don't think I was able to get it to work with yarn, I think that is why I switched it back to npm.
Regardless, I made the two changes you requested:
- Pinned to node version 18
- Reverted to use yarn
Please check and merge.
jonniebigodes
left a comment
There was a problem hiding this comment.
@natehouk one small item and this should be good to go. Let me know once you've addressed it and I'll gladly merge it.
Have a fantastic week.
Stay safe
| with: | ||
| node-version: 18 | ||
| cache: 'yarn' | ||
| - run: yarn ci |
There was a problem hiding this comment.
@natehouk Sorry for not being explicit. What I meant to say was to remove only the ci option, as you'll need to run the yarn command to install the dependencies.
There was a problem hiding this comment.
@jonniebigodes I have removed the line as requested. |
jonniebigodes
left a comment
There was a problem hiding this comment.
@natehouk thanks for addressing the feedback so promptly. Appreciate it 🙏 ! We're in the clear. I'll get it merged once the checklist goes through.
Have a fantastic day.
Stay safe
What I did
Update to fix an error due to
fetch-depthnot being set to 0. With the current example, the following error occurs:This PR also switches the example from
yarntonpm, but that can be reverted if necessary. However it is likely that most beginners following the tutorial are using npm and not yarn.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Trigger example GitHub action
.github/workflows/chromatic.ymlas exemplified in documentation and ensure it runs without error.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>