Scripts: Fix the changelog writer to escape doublequotes#23996
Conversation
JReinhold
left a comment
There was a problem hiding this comment.
This looks good to me.
Currently changelogs for minors/majors are handwritten, including the version JSONs. That's because the automated release will only contain the changes since the most recent prerelease, but we need it to contain all the changes since the most recent minor, so we hand-merge all the changes from the all the prereleases.
Therefore, I think you should add a sentence about this issue to this parts of the docs as well: https://github.com/storybookjs/storybook/blob/main/CONTRIBUTING/RELEASING.md?plain=1#L318-L320
|
@JReinhold If they have to make manual changes to latest.json they shouldn't have this issue as their editor would tell them that they JSON format if broken |
…ilder Scripts: Fix the changelog writer to escape doublequotes (cherry picked from commit 7669124)
…ilder Scripts: Fix the changelog writer to escape doublequotes (cherry picked from commit 7669124)
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.