Skip to content

Build: Migrate registry util script from JS to TS#23976

Merged
yannbf merged 21 commits into
storybookjs:nextfrom
mastrzyz:mastrzyz/remove_concurency_ts_issue
Sep 19, 2023
Merged

Build: Migrate registry util script from JS to TS#23976
yannbf merged 21 commits into
storybookjs:nextfrom
mastrzyz:mastrzyz/remove_concurency_ts_issue

Conversation

@mastrzyz
Copy link
Copy Markdown
Contributor

@mastrzyz mastrzyz commented Aug 28, 2023

What I did

  • Migrated the concurrency file to TS
  • Removed dead function not used anywhere
  • Eliminated code debt violation

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • compiler

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

shilman and others added 19 commits August 16, 2023 09:12
…ry-indexer

Index: Fix `*.story.*` CSF indexing
(cherry picked from commit 377f7f9)
…elism-count-check

Build: Add parallelism count check to CI
(cherry picked from commit f495b35)
…late-file

Build: Fix ts errors in get-template
(cherry picked from commit 78c6527)
…rom-7.3.1

Release: Merge patches to `main` (without version bump)
…rbert/react-peerdep-webpack-builder-removal

Maintenance: Revert "WebpackBuilder: Remove need for `react` as peerDependency"
(cherry picked from commit 946ea82)
@mastrzyz mastrzyz changed the title Mastrzyz/remove concurency ts issue Build: Migrate registry util script from JS to TS Aug 28, 2023
@yannbf
Copy link
Copy Markdown
Member

yannbf commented Sep 4, 2023

Hey @ndelangen could you please assist? Thank you!

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Sep 4, 2023
@yannbf yannbf merged commit d4d799c into storybookjs:next Sep 19, 2023
@kylegach kylegach removed their request for review September 19, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants