Skip to content

Docs: Adds videos for additional Doc Blocks#23958

Merged
kylegach merged 1 commit into
nextfrom
docs_documentation_video_callout
Aug 29, 2023
Merged

Docs: Adds videos for additional Doc Blocks#23958
kylegach merged 1 commit into
nextfrom
docs_documentation_video_callout

Conversation

@jonniebigodes
Copy link
Copy Markdown
Contributor

What I did

This pull request extends the existing video coverage for Doc Blocks, in this case, for Typeset, Icongallery, and ColorPalette.

Checklist for Contributors

Testing

  1. Follow the steps in the contributing instructions for this branch, docs_documentation_video_callout.
  2. Open the relevant documentation, and the videos should be available.

@chantastic sorry for the delay on this, but when you and @kylegach have a moment, can you take a look at this and let me know of any feedback? Thanks in advance.

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Aug 26, 2023
@jonniebigodes jonniebigodes self-assigned this Aug 26, 2023
@kylegach kylegach merged commit 1a3850d into next Aug 29, 2023
@kylegach kylegach deleted the docs_documentation_video_callout branch August 29, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants